Update SQL server to TagManager #20424
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| @@ -322,7 +321,7 @@ def _rows_to_raw_statement_events(self, rows): | |||
| "ddagentversion": datadog_agent.get_version(), | |||
| "ddsource": "sqlserver", | |||
| "dbm_type": "rqt", | |||
| "ddtags": ",".join(self.tags), | |||
| "ddtags": ",".join(self._check.tag_manager.get_tags()), | |||
There was a problem hiding this comment.
Why does this use ",".join() but all other events just pass the tag list? I know it's how it was previously but curious if it matters
There was a problem hiding this comment.
No idea, some sort of legacy choice that we could try and clean up
Co-authored-by: Eric Weaver <eweaver755@gmail.com>
Co-authored-by: Eric Weaver <eweaver755@gmail.com>
Co-authored-by: Eric Weaver <eweaver755@gmail.com>
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not beco 8000 me mergeable within the expected time |
What does this PR do?
Motivation
Previously certain tags were set before the static info cache had been populated. This led to placeholders appearing in database instance identifiers.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged