8000 Reapply Mac Audit Logs after fix the dependency. by nubtron · Pull Request #20553 · DataDog/integrations-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reapply Mac Audit Logs after fix the dependency. #20553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reapply Mac Audit Logs after fix the dependency. #20553

wants to merge 2 commits into from

Conversation

nubtron
Copy link
Contributor
@nubtron nubtron commented Jun 19, 2025

What does this PR do?

This PR reapplies the reverted Mac Audit Logs integration first merged here. It fixes the depenency issue that motivated the revert.

Motivation

The lxml library was set to 5.3.2, which conflicts with the existing lxml 5.1.1 dependency. Also, it wasn't pinned.
This wasn't detected by our CI because it was in the "dependencies" section rather than in the [project.optional-dependencies] section, where it belongs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@nubtron nubtron requested review from a team as code owners June 19, 2025 12:49
@nubtron
Copy link
Contributor Author
nubtron commented Jun 19, 2025

Closing the PR to edit the title.

@nubtron nubtron closed this Jun 19, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.79096% with 68 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (5ca83b8) to head (0f5b418).
Report is 9 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mac_audit_logs 80.79% <80.79%> (?)
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nubtron nubtron deleted the nubtron/reapply-mac-audit-logs branch June 19, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev/testing dev/tooling documentation integration/mac_audit_logs qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation team/logs-backend team/logs-integrations-reviewers team/saas-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nubtron
0