8000 [SDBM-1807] Only submit plan events with plan definitions by natashadada · Pull Request #20584 · DataDog/integrations-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SDBM-1807] Only submit plan events with plan definitions #20584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[SDBM-1807] Only submit plan events with plan definitions #20584

wants to merge 5 commits into from

Conversation

natashadada
Copy link
Contributor
@natashadada natashadada commented Jun 24, 2025 •
edited
Loading

There are cases where we are not able get a plan from the cache (ex. sqlserver evicted the relevant plan to free up memory). When this happens, we still submit a plan event with a plan signature but no plan definition. When querying for plans this is a bit weird since we say we've collected a plan because we see a plan event with a plan signature but we don't have the actual plan to show the user.

I see a few options here:

  1. We can not submit plan events if we don't have the plan definition. This makes the most sense to me right now but would appreciate other perspectives/things I may be missing
  2. We could submit the plan with a collection_error that says the plan is null because it was not found
  3. We could leave plan collection as is and change the way we query for plans on the front end (only query for plan events with a plan definition)

This PR is for option 1. We now won't see collection errors so I'm logging them instead but not sure what best practice is here.

Support ticket: https://datadoghq.atlassian.net/browse/SDBM-1807

@natashadada natashadada added the qa/skip-qa Automatically skip this PR for the next QA label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
agent/review-requested ecosystems/review-requested integration/sqlserver product/review-requested qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natashadada
0