8000 fix include path in the sandbox and tests by David-Haim · Pull Request #17 · David-Haim/concurrencpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix include path in the sandbox and tests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2020
Merged

fix include path in the sandbox and tests #17

merged 2 commits into from
Oct 16, 2020

Conversation

David-Haim
Copy link
Owner

No description provided.

@David-Haim
Copy link
Owner Author

@friendlyanon
I changed some includes so I would be able to build the sandbox and tests locally (without the change they don't compile)
Can you take a sneak peak to see I haven't broken anything?

friendlyanon
friendlyanon reviewed Oct 16, 2020
View reviewed changes
@friendlyanon
Copy link
Contributor

That's on me, apologies. Must've missed some commits when cherry picking.

@David-Haim @friendlyanon
Update test/include/tests/test_utils/executor_shutdowner.h
3836fd0 
Co-authored-by: friendlyanon <1736896+friendlyanon@users.noreply.github.com>
@David-Haim
Copy link
Owner Author

That's ok, We've had some massive changes.

@David-Haim David-Haim merged commit b67c214 into develop Oct 16, 2020
@David-Haim David-Haim deleted the fix_include_path branch October 16, 2020 14:06
@chausner chausner mentioned this pull request Sep 5, 2021
Closed
David-Haim added a commit that referenced this pull request Apr 14, 2023
@David-Haim
executors redesign #17
70f3a4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friendlyanon friendlyanon friendlyanon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@David-Haim @friendlyanon
0