8000 Error handling for debugging by kkovarik · Pull Request #32 · Doccrazy/keycloak-protocol-cas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Oct 12, 2020. It is now read-only.

Error handling for debugging #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkovarik
Copy link

Error handling tweaks

Recently was trying to use plugin on Keycloak (6.x), some minor tweaks that came out of it:

Try catch in ContentTypeHelper

Changed the try cache exception - maybe because of using older version of keycloak? Or some classpath issues, as on my instance there was org.jboss.resteasy.spi.BadRequestException instead of javax.ws.rs.BadRequestException. Changed to general Exception as it really doesn´t matter why recognition failed.

Logging general exception in ValidateEndpoint

Previous error was not easily debugged without it, as the exception was not logged properly. Had another issues with missing jaxb on classpath that needed to be properly logged as well. If something unexpected happens, it should be logged and at least some UUID of error added.

@hanusto
Copy link
hanusto commented Feb 12, 2020

@Doccrazy can you please do review?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0