8000 New Mass-Upload feature causes Payload issues. · Issue #72 · Drop-OSS/drop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New Mass-Upload feature causes Payload issues. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SCOPEDDXYZ opened this issue Jun 2, 2025 · 7 comments · Fixed by #116
Closed

New Mass-Upload feature causes Payload issues. #72

SCOPEDDXYZ opened this issue Jun 2, 2025 · 7 comments · Fixed by #116

Comments

@SCOPEDDXYZ
Copy link

With the addition of the new mass-uploading of images, it seems that it combines the file sizes, and causes a "Payload too large." issue. I'm mainly assuming here, but I feel this could be fixed by staggering the uploads, rather than doing all the uploads at once. I feel this wouldn't hinder user experience either, as it'd be literal seconds for most people. In the future, if videos were to be added, I feel they may need broken up into small chunks to be uploaded or this will continue to be an issue. I've attached a screenshot of what it looks like when I upload anymore than 3 images.

Image

@DecDuck
Copy link
Member
DecDuck commented Jun 3, 2025

Yeah this issue is kinda difficult to deal with. We can theoretically just keep trying until we no longer get "Payload Too Large", but this issue only affects Drop instances behind reverse proxies, and can be solved with changing the proxy's configuration.

@SCOPEDDXYZ
Copy link
Author

Odd, I have it reverse proxied, but I use the direct IP to manage it. Weird I still get the issue.

@DecDuck
Copy link
Member
DecDuck commented Jun 3, 2025

Ohhh, it's on our end then.

@Huskydog9988 I think this is due to the nuxt-security module then. Do you think it's better to disable the upload limit or break up the upload requests?

@SCOPEDDXYZ
Copy link
Author

I think best bet is to honestly break up the upload requests. Break them down into like maybe 5-10mb segments that way users with unstable connection can have slightly better stability.

@Huskydog9988
Copy link
Contributor

Probably both is a good idea. Maybe using https://uppy.io/ or the FileReader class might help us with the chunking stuff? I haven't done much large uploads on the browser so I'm not quite sure tbh.

@DecDuck
Copy link
Member
DecDuck commented Jun 3, 2025

We're using multipart forms which does the chunking for us, it's just blocking it because it's all part of the same request. To get around this we'd need to send separate requests for it.

@Huskydog9988
Copy link
Contributor

Yes, i was under the impression tus, a file upload spec that uppy.io uses, was multiple requests, but it seems to all just be one...

DecDuck added a commit that referenced this issue Jun 10, 2025
@DecDuck DecDuck linked a pull request Jun 10, 2025 that will close this issue
DecDuck added a commit that referenced this issue Jun 10, 2025
* fix: missing CheckIcon import in LanguageSelector

* fix: #114 and error handling

* fix: #97

* fix: lint

* feat: #104

* fix: #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
0