i18n Support and Task improvements #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecDuck
reviewed
Jun 4, 2025
|
Don't have every string added to the locale files, but should be all the ones not being worked on elsewhere. Think I also got all the time stuff using the new i18n time formatter. |
|
Are there ESLint rules to highlight missing strings? I saw you added some ESLint config. |
|
Yes, the eslint rules should do that for all the vue files. Server side we should make the errors translated too where we can, but eslint doesn't mark those. |
DecDuck
approved these changes
Jun 4, 2025
|
for future reference, arktype discission on i18n: arktypeio/arktype#819 arktypeio/arktype#1276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53, and lays the groundwork for #52
A new version of #66, apparently renaming a branch breaks prs, I didn't know that. woops