Redesign of language selector #100 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added full pirate translations. @Huskydog9988 some of the elements (like the navbar) aren't changing when the language is set. Any idea why? |
|
Wrapping the strings in computed fields like this works, but I'm looking for a better solution. |
|
We can wrap the whole thing in a computed, and it works a treat: |
|
Seems like computed solves that nicely. For the language selector, can we keep that in a separate component? Some changes I’m introducing in #102 adds even more logic around it. |
|
Yep, I'll refactor it shortly. I'm currently working on #90 and I don't want to lose my place. |
…latform a very very necessary change
DecDuck
added a commit
that referenced
this pull request
Jun 8, 2025
* feat: add new language selector in footer, add pirate language * fix: translations in title bar not updating * chore: refactor into separate component * fix: update translate url * fix: update pirate translation to use "ship" instead of "plank" for platform a very very necessary change
DecDuck
added a commit
that referenced
this pull request
Jun 8, 2025
* feat: add new language selector in footer, add pirate language * fix: translations in title bar not updating * chore: refactor into separate component * fix: update translate url * fix: update pirate translation to use "ship" instead of "plank" for platform a very very necessary change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.