2.0.0rc2 - Updates to enable PyPi hosting. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngochieu642
reviewed
Jul 24, 2024
src/hostile_eit/util.py
Outdated
| @@ -33,7 +33,7 @@ def choose_default_thread_count(cpu_count: int) -> int: | |||
| CACHE_DIR = ( | |||
| Path(os.environ.get("HOSTILE_CACHE_DIR", "")) | |||
| if os.environ.get("HOSTILE_CACHE_DIR") | |||
| else Path(user_data_dir("hostile-eit", "Bede Constantinides")) | |||
| else Path(user_data_dir("hostile_eit-eit", "Bede Constantinides")) | |||
There was a problem hiding this comment.
Could I ask why we need to change this?
There was a problem hiding this comment.
Oh we definitely don't need this one, that's a bug!
ngochieu642
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon going to upload to PyPi, I realised this would upload to hostile which of course already exists!
Changed the code references so that pyproject.toml is correctly used, the entrypoint is still the same hostile --version etc.
Also first pass at a reusable GitHub workflow: https://github.com/EIT-Pathogena/common-workflows/blob/main/.github/workflows/build-and-push-to-ocir.yml