8000 Consolidated FilePicker and FileExplorer by nelsonni · Pull Request #97 · EPICLab/synectic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consolidated FilePicker and FileExplorer #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 31, 2020
Merged

Consolidated FilePicker and FileExplorer #97

merged 8 commits into from
Mar 31, 2020

Conversation

nelsonni
Copy link
Member
@nelsonni nelsonni commented Mar 30, 2020 •
edited
Loading

Includes:

  • The filetree.ts file contained redundant IO functions that were folded into io.ts.
  • The recursive filetree.exractFileTreeNames function was specifically replaced by io.readDirAsyncDeep, however, it is not currently being used.
  • The recursive directory descent now occurs as part of the containsDecorator and contentDecorator in the metafiles.extractMetafile workflow.
  • FileExplorer component is simplified to be entirely contained in FileExplorer.tsx, without the need for a separate RenderTree.ts file to process sub-components.
  • The git.ts wrapper API for isomorphic-git now returns JavaScript objects with named fields, instead of unnamed tuple Arrays.
  • Metadir type was subsumed into the Metafile type through the addition of a contains field on the later that contains UUIDs for both child directories and files.
  • loadFE function was made redundant through the consolidation and removal of Metadir type, and the subsequent removal of Metadir reducers and workflow.
  • Tests updated for all modified APIs, components, and functionality.

@nelsonni nelsonni added the feature Feature requests or improvements label Mar 30, 2020
@nelsonni nelsonni requested a review from jettseale March 30, 2020 19:57
@nelsonni nelsonni linked an issue Mar 30, 2020 that may be closed by this pull request
File Explorer card #54
Closed
4 tasks
@nelsonni nelsonni self-assigned this Mar 30, 2020
jettseale
jettseale approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator
@jettseale jettseale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good.

@nelsonni nelsonni merged commit 7d9de9f into development Mar 31, 2020
@nelsonni nelsonni deleted the feature/consolidated-filepicker branch March 31, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jettseale jettseale jettseale approved these changes

Assignees

@nelsonni nelsonni

Labels
feature Feature requests or improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Explorer card
2 participants
@nelsonni @jettseale
0