Merge dev state d661791 #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating dev
- Added checks for `cite_source`, `cite_label`, and `cite_string` to handle cases where values are empty or NA, setting them to NULL if no valid entries exist. - Streamlined the filtering process by removing "unknown" entries and splitting values only after ensuring non-empty data. - This change improves robustness in filtering by preventing empty or "unknown" entries from appearing in the final list of sources, labels, and strings.
Update dev from main (after changes to deploy actions)
|
@LukasWallrich let me know if this looks okay with you. I should have merged the dev with the main prior to pushing the most recent changes on dev, but I figured this out to make sure we could get to the same place. |
|
Going ahead with merge as tests are good and dev had been stable/working for quite some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges a previous version of the dev branch into the main. This should have been done before recent pushes to the dev from my local... still learning.