8000 Winding definition improvements by Eomys · Pull Request #612 · Eomys/pyleecan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Winding definition improvements #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Apr 27, 2023
Merged

Winding definition improvements #612

merged 44 commits into from
Apr 27, 2023

Conversation

Eomys
Copy link
Collaborator
@Eomys Eomys commented Mar 16, 2023

No description provided.

@BonneelP
Copy link
Collaborator

Hello all,

With this PR we will rework how the winding are defined in the GUI to be more understandable and flexible. Here are some of the modifications that we will investigate:

  • N*3 phases
  • delta / star connection
  • Step "Stator Lamination" before "Stator Conductor" to have L1 set to be able to compute winding mass/resistance in Conductor
  • Few renaming for more clarity
  • Plot radial pattern and Plot linear pattern from swat-em
    image

Best regards,
Pierre

Ps: I think I will wait to end this PR before releasing 1.5.0

helene-t and others added 27 commits March 17, 2023 17:58
[NF] add winding connections to lamination plot
2ca7494
Merge branch 'Branch_Dev_A' of https://github.com/EOMYS-Public/pyleecan…
dcda048 
… into Branch_Dev_A
@BaptisteMadery14
[NF] Reworking Winding GUI:
477214c 
- removing winding schematics, preview button (will be redundant with the rework plot of machine inside the widget)
- renaming 'Coil pitch' to 'Throw'
- Adding button for the new radial and linear pattern plots
@BenjaminGabet
[NF] Adding two new tests that create a new machine from scratch(Priu…
e99da7b 
…s & Benchmark)
@BenjaminGabet
Merge branch 'Branch_Dev_A' of github.com:EOMYS-Public/pyleecan into …
b802a33 
…Branch_Dev_A
@BaptisteMadery14
[NF] Making plot button inside SWinding work
62e813e
@BenjaminGabet
[CC & NF] Making units between [], improving tests & create a new one
4163c0c
@BenjaminGabet
[NF] new test for Railway
6cbdec2
@BenjaminGabet
Pull Dev_B part 1
f542ccc
@BenjaminGabet
Merge branch 'Branch_Dev_B' of https://github.com/EOMYS-Public/pyleecan…
008b056 
… into Branch_Dev_A
@BenjaminGabet
Merge branch 'Branch_Dev_B' of https://github.com/EOMYS-Public/pyleecan…
d241f5b 
… into Branch_Dev_A
@BenjaminGabet
Merge branch 'Branch_Dev_B' of https://github.com/EOMYS-Public/pyleecan…
6b03f0b 
… into Branch_Dev_A
@BenjaminGabet
Merge branch 'Branch_Dev_B' of https://github.com/EOMYS-Public/pyleecan…
1a46d0f 
… into Branch_Dev_A
@BenjaminGabet
[BC] bug correction in tests that create new machines
11041f9
@BaptisteMadery14
[NF] Reworking Machine/Winding/plot_linear.py method based on swat-em…
156dea3 
… overhan_plot method to implement it inside pyleecan GUI
@BaptisteMadery14
Merge branch 'Branch_Dev_A' of https://github.com/EOMYS-Public/pyleecan…
8f05875 
… into Branch_Dev_A

# Conflicts:
#	pyleecan/GUI/Dialog/DMachineSetup/SWinding/SWinding.py
@BaptisteMadery14
[CO] adding docstring + changing how slot number is displayed (annota…
9dc2df7 
…te instead of text) + cleaning imports
@BaptisteMadery14
[BC] Adapting plot linear depending on the number of layer + cleaning…
7a91b00 
… SWinding typo after merge
@BonneelP
Merge branch 'master' of https://github.com/Eomys/pyleecan into Branc…
57e2131 
…h_Dev_A
@BaptisteMadery14
[CO] Adding is_max_sym parameter to only plot the winding for a perio…
f073e11 
…d + adding reference to swat-em in the docstring
@BaptisteMadery14
[BC] Fixing bug where some arrow on plot_linear were at the wrong loc… 10000
eb0f8e8 
…ation
@BaptisteMadery14
[CO] Finlaizing test_plot_linear inside test_Winding_plot.py
65bcf20
@BaptisteMadery14
Merge branch 'Branch_Dev_A' of https://github.com/EOMYS-Public/pyleecan…
51f18be 
… into Branch_Dev_A
@BaptisteMadery14
[CO] Making sure that plot of the winding radial pattern is correct f…
d463f15 
…or machine with double layer
@BaptisteMadery14
[CO] Adding winding transformation for plot method to plot winding ra…
160b741 
…dial pattern
@BaptisteMadery14
[CO] Improving LamSlotWind/plot.py method to make it more robust to t…
2b8db1e 
…ransformation
@BaptisteMadery14
[CO] Making winding radial pattern more robust and easier to read + t…
705dbf0 
…aking WIndingUD case into account
@BaptisteMadery14
[BC] fixing bug inside find_wind_phase_color when there were note eno…
5b67c03 
…ugh colors for all phase (looping on them)
@BaptisteMadery14
[CO] adding possibility to only plot winding connection of phase A
a335ed2
@BaptisteMadery14
[CO] Finalizing test on plot winding radial pattern method
e673f7e
@BaptisteMadery14
[CO] Taking transformation into inside plot_linear method
6d726c6
@BaptisteMadery14
[CO] Changing name of figure when plot winding radial pattern
9bd074f
@BaptisteMadery14
[CO] Taking reverse winding transformation into account
42fd54b
@BaptisteMadery14
[BC] Solve bug on plot_linear if the point to split was not exactly o…
4d6d88b 
…n the border (using round function)
@BaptisteMadery14
[CO] Changing how coil are drawn depending on layer direction
aad1a66
@BaptisteMadery14
[BC] reverting changes inside SWinding.ui causing bug with qtdesigner
991a412
@BaptisteMadery14
[NF] Rework of SWinding interface: button, removing schematics, addin…
46a8bd3 
…g tooltip and renaming coil pitch to throw
@BaptisteMadery14
[NF) regen class
a32977c
@BaptisteMadery14
[CO] Changing Ncspc and Ntspc displayed in output of SWinding by the …
1111364 
…full name
@BaptisteMadery14
[NF] Replacing NLayer spinbox and change_layer checkBox by a combobox…
33d990a 
… to simplify GUI
@BaptisteMadery14
[CO] adding legend to the lamination plot inside SWinding and separat…
0af021b 
…ing phase sign and phase color inside the legend to make it clearer
@BaptisteMadery14
[CO] Throw tooltip + changing label for nb of slot + pole pairs
416256f
@BonneelP BonneelP merged commit 9bd264f into Eomys:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eomys @BonneelP @BaptisteMadery14 @BenjaminGabet
0