8000 Search for run names. by csordasmarton · Pull Request #753 · Ericsson/codechecker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Search for run names. #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2017
Merged

Search for run names. #753

merged 1 commit into from
Jul 31, 2017

Conversation

csordasmarton
Copy link
Contributor

Fixes #733

@csordasmarton csordasmarton added this to the 6.0 pre2 milestone Jul 24, 2017
@csordasmarton csordasmarton added the WIP 💣 Work In Progress label Jul 24, 2017
@csordasmarton csordasmarton removed the WIP 💣 Work In Progress label Jul 24, 2017
Xazax-hun
Xazax-hun approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor
@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case we want a prefix search LGTM!

libcodechecker/server/client_db_access_handler.py Outdated
q = session.query(Run, stmt.c.report_count)

if run_name_filter is not None:
q = q.filter(Run.name.like(run_name_filter + '%'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are doing a prefix search?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we shan't. 🙁 Infix searching could be more appropriate, especially for the naming conventions used internally. :/

whisperity
whisperity reviewed Jul 25, 2017
View reviewed changes
www/scripts/codecheckerviewer/ListOfRuns.js Outdated

this._runFilter = new TextBox({
id : 'runs-filter',
placeHolder : 'Run name filter...',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better placeholder would be Search for runs...?

whisperity
whisperity requested changes Jul 25, 2017
View reviewed changes
Copy link
Contributor
@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with infix/substring searching, instead of prefix ones.

@whisperity whisperity modified the milestones: 6.0 pre1 , 6.0 pre2 Jul 27, 2017
gyorb
gyorb reviewed Jul 27, 2017
View reviewed changes
tests/functional/report_viewer_api/test_run_filter.py Outdated
print('Running ' + test_class + ' tests in ' + test_workspace)

# Get the clang version which is tested.
self._clang_to_test = env.clang_to_test()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variables in the tests could be cleaned up.

@whisperity whisperity force-pushed the < 8000 span class=" css-truncate-target">version6 branch 2 times, most recently from d47cf59 to 6c167b7 Compare July 27, 2017 12:47
@whisperity whisperity merged commit f0d16c8 into Ericsson:version6 Jul 31, 2017
@csordasmarton csordasmarton deleted the runname_filter branch August 4, 2017 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazax-hun Xazax-hun Xazax-hun approved these changes

@whisperity whisperity whisperity approved these changes

@gyorb gyorb gyorb approved these changes

Assignees
No one assigned
Labels
enhancement 🌟 GUI 🎨
Projects
None yet
Milestone
6.0 pre1
Development

Successfully merging this pull request may close these issues.
4 participants
@csordasmarton @Xazax-hun @whisperity @gyorb
0