fix skip for header files #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
reviewed
Aug 31, 2017
| fids, kept_diagnostics = fids_in_path(report_data, file_ids_to_remove) | ||
| report_data['diagnostics'] = kept_diagnostics | ||
|
|
||
| remove_file = True |
There was a problem hiding this comment.
What does this loop filter exactly? If we mark a file to be removed, but it is still used somewhere else?
There was a problem hiding this comment.
In the plist there is a files array with all the files where a report was found. We can safely remove a file from this list only if that file is not found in any of the other report paths.
475cd32 to
46e7a54
Compare
whisperity
approved these changes
Aug 31, 2017
4712f1a to
ba2d98f
Compare
Skipping reports in header files included by a c/cpp file can be done only after the analysis is done and the plist output is generated. With this modification if there is a skip file with headers in it, the reports from the header will be removed from the generated plist file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping reports in header files included by a c/cpp
file can be done only after the analysis is done and the
plist output is generated.
With this modification if there is a skip file with headers
in it, the reports from the header will be removed from the
generated plist file.
resolves #812