fix(graphql): pin the version of assets in the graphql playground #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
commented
May 6, 2025
Comment on lines
+396
to
+403
| let raw_html = raw_html.replace( | ||
| "https://unpkg.com/graphiql/graphiql.min.js", | ||
| "https://unpkg.com/graphiql@3/graphiql.min.js", | ||
| ); | ||
| let raw_html = raw_html.replace( | ||
| "https://unpkg.com/graphiql/graphiql.min.css", | ||
| "https://unpkg.com/graphiql@3/graphiql.min.css", | ||
| ); |
There was a problem hiding this comment.
while we could get away with a singular replace, i.e
Suggested change
| let raw_html = raw_html.replace( | |
| "https://unpkg.com/graphiql/graphiql.min.js", | |
| "https://unpkg.com/graphiql@3/graphiql.min.js", | |
| ); | |
| let raw_html = raw_html.replace( | |
| "https://unpkg.com/graphiql/graphiql.min.css", | |
| "https://unpkg.com/graphiql@3/graphiql.min.css", | |
| ); | |
| let raw_html = raw_html.replace( | |
| "https://unpkg.com/graphiql/graphiql.min.", | |
| "https://unpkg.com/graphiql@3/graphiql.min.", | |
| ); |
i would rather have it be explicit about which assets we are pinning, and since this part of the code only runs once, it seems ok imo
netrome
approved these changes
May 6, 2025
Comment on lines
+396
to
+403
| let raw_html = raw_html.replace( | ||
| "https://unpkg.com/graphiql/graphiql.min.js", | ||
| "https://unpkg.com/graphiql@3/graphiql.min.js", | ||
| ); | ||
| let raw_html = raw_html.replace( | ||
| "https://unpkg.com/graphiql/graphiql.min.css", | ||
| "https://unpkg.com/graphiql@3/graphiql.min.css", | ||
| ); |
xgreenx
approved these changes
May 20, 2025
Dentosal
added a commit
that referenced
this pull request
May 26, 2025
## Version 0.44.0 ### Breaking - [2887](#2887): Bump Rust version to `1.85.0`. Starting with this release, newly generated WASM state transition functions are no longer compatible with old versions of the `fuel-core`. So, the change breaks forward compatibility for the network and each node should start to use a new `fuel-core` release. - [2943](#2943): Registry root calculation for compression tables no longer accounts for the evictor cache. - [2947](#2947): Upgrade to 2024 Rust edition. - [2958](#2958): Changed return type of `balance` endpoint from `u64` to `u128` - [3002](#3002): Update `fuel-vm` to `0.61.1`. In doing this, we've changed Receipts to use the `SubId` scalar type for sub asset IDs. ### Added - [2954](#2954): Made `registry` mod public in `fuel-core-compression` - [2956](#2956): Add excluded_contract filter to extract of transaction from TxPool. - [2994](#2994): Simple makefile with basic commands. - [3004](#3004): Additional error logs for Ethereum provider failures. ### Changed - [3021](#3021): Updated fuel-vm to 0.62.0, see https://github.com/fuelLabs/fuel-vm/releases/v0.62.0 ### Fixed - [2969](#2969): Ensure that vm heap memory is zeroed out on rellocation after `reset`. Adds support for `GM::GetGasPrice` Bumps `fuel-vm` to `0.60.2`. - [2984](#2984): Fix client coins endpoint so that passing `None` for `asset_id` no longer defaults to `AssetId::default()` but correctly returns all asset types. - [2987](#2987): Make txpool pre-conf broadcast conditional on there being some txs in the list - [2989](#2989): Prevent syncing compression database from genesis if override cli arg `--da-compression-starting-height` is provided. - [2992](#2992): Make sure assemble tx doesn't count message data inputs as spendable inputs for covering fee - [2993](#2993): Pin the graphiql playground to v3, and cache the result to be reused across multiple calls to render the playground. ### Removed - [2955](#2955): Remove unnecessary lifetime constraints on fuel-core-client. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
playground broken across various networks due to async-graphql/async-graphql#1703
Description
2 main things -
/v1/playground. previously we were re-rendering the template every time, which might not be a good solutionChecklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]