8000 New PR to add Raman App in NOMAD by RonHildebrandt · Pull Request #26 · FAIRmat-NFDI/pynxtools-raman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New PR to add Raman App in NOMAD #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

RonHildebrandt
Copy link
Collaborator
@RonHildebrandt RonHildebrandt commented Feb 17, 2025

New PR, because an other rebase did not work out.

See old preview of Raman App in NOMAD here: #22

The old PR diverged here: ee0b689 due to the merge of this PR: #18

The initial commit included these commits:
098ac20
a11c390
3849c83

@RonHildebrandt RonHildebrandt self-assigned this Feb 17, 2025
@RonHildebrandt RonHildebrandt force-pushed the nomad_entry_point_and_raman_app_nbr3 branch from e6ec3f9 to 223bfde Compare February 20, 2025 09:39
@RonHildebrandt
Copy link
Collaborator Author

I updated the layout, as the initial preview of filter should be rather short. Moved everything possible to the sidemenu of filters.
Here is an example:
grafik
grafik

@RonHildebrandt RonHildebrandt marked this pull request as ready for review February 24, 2025 10:12
< 8000 a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/RonHildebrandt/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/RonHildebrandt">@RonHildebrandt RonHildebrandt mentioned this pull request Feb 24, 2025
Copy link
Contributor
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RonHildebrandt RonHildebrandt merged commit ca8f058 into main Feb 24, 2025
6 checks passed
@lukaspie lukaspie deleted the nomad_entry_point_and_raman_app_nbr3 branch March 26, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0