Mpes reader fix #44
Merged
Mpes reader fix #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domna
approved these changes
Sep 14, 2022
| f"[info]: Path {key} not found. " | ||
| f"Skipping the entry.", | ||
| ) | ||
| if key not in eln_data_dict: |
There was a problem hiding this comment.
I think we should refine that at one point. That we just fill in the keys present in the xarray and the keys in the eln and let the internal logic of the parser throw the errors if anything is missing.
But I think for now this hot fix is fine.
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* reader bug fix * fix ELN example yaml file * small edits in config.json * Updates ref mpes log Co-authored-by: domna <florian.dobener@physik.hu-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.