Better dependency management for dev, standalone, and a Nomad inst 8000 all #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbrock
reviewed
Sep 30, 2022
|
|
||
| if __name__ == '__main__': | ||
| main() | ||
| setup() |
There was a problem hiding this comment.
will it ensure packaging the xml files from nexus definitinos?
There was a problem hiding this comment.
This is still in draft. There are many other developments happening in Nomad that I am waiting for. But I'll add this point as a TODO above so that we don't forget this before merging.
…t how tests should finally before structured, then the tests and absolute paths in the ipynbs and code sections should be changed
…d compiling a dev-requirements locally successfully
sanbrock
approved these changes
Oct 7, 2022
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
…#50) * Added a pip-compile locked requirements for devs * Reverted nomad-lab install back * Fixed missing astroid version * cleanup + ease on dev reqs * Added a relaxed requirements.txt for installation with Nomad * Unrelaxed pyproject.toml dev reqs and reverted xarray to older version * Allowed python3.7 and fixed dask[array] version * Merge adapt-nexus-to-metainfo-changes and CI updates * cleanup * Brought in requirements.txt * draft refactoring and reorganizing of nomad-parser-nexus, decide first how tests should finally before structured, then the tests and absolute paths in the ipynbs and code sections should be changed * renaming tools; adding and fixing unit tests * fix some linting issues * addig reference data for testing nexus checker * fixing linting issues; adding test reference file * bringing Example to front * tested ipynb notebooks, added jupyterlab_h5web to the environment * 7D8A improved descriptions, and placed jupyterlab in pyproject toml, tested compiling a dev-requirements locally successfully * updating readme.md as a result of testing * Added nexus definitions to the module package * fixing README files and the ipynb for APM * use dataconverter alias from command line * harmonising EM and MPES notebooks * Updated YAML file * Updated jupyter notebook for ellipsometry + DAT and YAML file * Delete ELLIPSOMETRY.NeXus.READER.EXAMPLE.02.ipynb * Delete test.yaml * fix data file locations Co-authored-by: Adam Fekete <fekad@users.noreply.github.com> Co-authored-by: Adam Fekete <adam@fekete.co.uk> Co-authored-by: kuehbachm <kuehbacm@hu-berlin.de> Co-authored-by: sanbrock <sandor.brockhauser@gmail.com> Co-authored-by: sanbrock <45483558+sanbrock@users.noreply.github.com> Co-authored-by: Carola Emminger <emminger.carola@physik.hu-berlin.de> Co-authored-by: cmmngr <98404894+cmmngr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40 #48 and #49.