accept open enumerations as no real enumerations #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuehbach
reviewed
Feb 21, 2025
mkuehbach
reviewed
Feb 21, 2025
| """ | ||
| Get the enumeration field from xml node | ||
| """ | ||
| enumeration = xml_node.find("nx:enumeration", __XML_NAMESPACES) | ||
| if enumeration is None: | ||
| return None | ||
| return None, None |
There was a problem hiding this comment.
None is not bool why not false?
There was a problem hiding this comment.
None is neither True, nor False.
There was a problem hiding this comment.
clear your return type annotation for the second one is bool though i.e. constrained would using that be cleaner,, agree does not change your logic in L550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.