8000 Example update by sanbrock · Pull Request #559 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Example update #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Mar 12, 2025
Merged

Example update #559

merged 27 commits into from
Mar 12, 2025

Conversation

sanbrock
Copy link
Collaborator

No description provided.

lukaspie
lukaspie approved these changes Feb 24, 2025
View reviewed changes
@lukaspie
Copy link
Collaborator
lukaspie commented Feb 24, 2025 •
edited
Loading

Sorry, didn't mean to approve, just wanted to ask the question above.

lukaspie
lukaspie reviewed Feb 24, 2025
View reviewed changes
sanbrock and others added 21 commits February 24, 2025 16:50
@sanbrock
seprate overview card for the notes
bc923da
@sanbrock
adding nexus_view to NexusDataConverter
666e028
@sanbrock
fix merge
50ad9d4
@sanbrock
add an example for simple data converstion using external_eln_data.ya…
57d5d5b 
…ml; NexusDataconverter: if eln data comes from NOMAD, write it to <output>_eln_data.yaml
@sanbrock
do not change input file list
fd0ec03
@sanbrock
split IV_temp example to 3 use cases
43b9ca2
@sanbrock
fix for bestfit; linting
7fc1707
@sanbrock
allow converting multiple files as fiter is set
2afa1fe
8000 @sanbrock
fix import
8562a1f
@sanbrock
fix inputs
36c1063
@sanbrock
fix output
fcd6187
@sanbrock
remove default value for filter
de71aa4
@Pepe-Marquez
Added Plotly superclass to NeXusMeasurement and use it for APM.
9cc5017
@sanbrock
similalry to all other base classes, convert NXobject also in NOMAD, …
a656002 
…so it becomes to Object
@lukaspie
update metainfo schema test
75b39e0
@sanbrock
fix tests
752d2cd
@sanbrock
updating definitions to get dev_tools features
b4138fc
< 8000 div data-view-component="true" class="TimelineItem-body">
@sanbrock
merging examples into subdirectories
29d7b60
@sanbrock
fixing tests
70c393b
@sanbrock
linting
b419ffd
@sanbrock
fixing tests for open enums
532a18d
This was referenced Mar 12, 2025
Open
Merged
lukaspie
lukaspie reviewed Mar 12, 2025
View reviewed changes
@sanbrock sanbrock merged commit d1a2bbb into master Mar 12, 2025
5 of 17 checks passed
@lukaspie lukaspie deleted the example_update branch March 12, 2025 14:22
@rettigl
Copy link
Collaborator
rettigl commented Mar 13, 2025

@sanbrock @lukaspie Why has this been merged if it breaks test?

@lukaspie
Copy link
Collaborator

@sanbrock @lukaspie Why has this been merged if it breaks test?

This was intentional because these tests will be fixed by #578 (all but one are actually fixed there).

@rettigl
Copy link
Collaborator
rettigl commented Mar 13, 2025

@sanbrock @lukaspie Why has this been merged if it breaks test?

This was intentional because these tests will be fixed by #578 (all but one are actually fixed there).

But why was this one then not first merged into #578? Now we have a broken master...

@lukaspie
Copy link
Collaborator

That was my suggestion, but Sandor wanted to merge right away...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sanbrock @lukaspie @rettigl @sherjeelshabih @Pepe-Marquez
0