8000 Adds value in output message during write error by sherjeelshabih · Pull Request #562 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds value in output message during write error #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Adds value in output message during write error #562

merged 1 commit into from
Feb 26, 2025

Conversation

sherjeelshabih
Copy link
Collaborator

No description provided.

rettigl
rettigl approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator
@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite helpful. What would also be helpful is to report the value and type if the data type does not match.

@sherjeelshabih sherjeelshabih merged commit 95b8003 into master Feb 26, 2025
17 checks passed
@sherjeelshabih sherjeelshabih deleted the improves-dataconverter-writer-error branch February 26, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

@lukaspie lukaspie Awaiting requested review from lukaspie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherjeelshabih @rettigl
0