8000 Update nexus def and add toposort package in pyproject.toml. by RubelMozumder · Pull Request #588 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update nexus def and add toposort package in pyproject.toml. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

Update nexus def and add toposort package in pyproject.toml. #588

merged 1 commit into from
Mar 17, 2025

Conversation

RubelMozumder
Copy link
Collaborator
@RubelMozumder RubelMozumder commented Mar 17, 2025 •
edited
Loading

This PR take care of

  • Missing toposort python package

@RubelMozumder RubelMozumder requested review from lukaspie and sanbrock and removed request for sanbrock March 17, 2025 08:50
@lukaspie
Copy link
Collaborator

We cannot update the definitons just like that, this is why we have #578. Please revert the definitions update here.

toposort seems to be missing from the toml indeed, so that's a good addition.

lukaspie
lukaspie approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator
@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubelMozumder RubelMozumder marked this pull request as ready for review March 17, 2025 09:08
@RubelMozumder RubelMozumder merged commit 78f0f6b into master Mar 17, 2025
4 of 17 checks passed
@RubelMozumder RubelMozumder deleted the missing_dependencies branch March 17, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubelMozumder @lukaspie
0