8000 attempt to fix ordering by fekad · Pull Request #60 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

attempt to fix ordering #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2022
Merged

attempt to fix ordering #60

merged 3 commits into from
Dec 19, 2022

Conversation

fekad
Copy link
Contributor
@fekad fekad commented Dec 19, 2022

The usage of glob function to load the files and which may return with an arbitrary order could cause random order in the generated metainfo file.

@fekad fekad requested a review from domna December 19, 2022 12:14
@domna domna merged commit 53cc5ae into master Dec 19, 2022
@domna domna deleted the fix_metainfo_order branch December 19, 2022 12:56
RubelMozumder pushed a commit that referenced this pull request Jun 28, 2023
@fekad @domna
Fix ordering of filenames and nx classes (#60)
101bccb 
* attempt to fix ordering

* Sort filenames for nx classes

* Pylinting

Co-authored-by: domna <florian.dobener@physik.hu-berlin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fekad @domna
0