Remodel the eln_mapper tool to use the NeXusTree
#607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbrock
reviewed
Mar 31, 2025
sanbrock
reviewed
Mar 31, 2025
sanbrock
reviewed
Mar 31, 2025
32f2ef8 to
6373779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started using the automatic ELN creation because I would like to have a parser in
pynxtools-xpsthat automatically creates a matching ELN for a given input file. In that progess, it became obvious that the currenteln_mappertool can be improved upon. Therefore, I completely remodelled it.ElnGeneratorclass.--optionality: choice between writing those concepts to the ELN that are either "required", "recommended", "optional".--filter-file: Possibility to pass a list of filters (each of which is a template key) to the ELN generation. Only those concepts that are in the list will be written. For the CLI tool, we allow passing files that are used as config files in the MultiFormatReader to define such filters. Only those concepts that are supposed to come from the ELN file (annotated by the@elnprefix) are selected for the generated ELN file.Can ideally be tested by running
generate_eln --nxdl NXxps --eln-type schema --optionality optional --filter-file src/pynxtools_xps/config/config_vms.jsonfrom the root of thepynxtools-xpsrepo.