8000 streamline build artifacts to upload job by lukaspie · Pull Request #616 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

streamline build artifacts to upload job #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

streamline build artifacts to upload job #616

merged 3 commits into from
Apr 7, 2025

Conversation

lukaspie
Copy link
Collaborator
@lukaspie lukaspie commented Apr 7, 2025

No description provided.

@lukaspie lukaspie requested a review from RubelMozumder April 7, 2025 11:16
RubelMozumder
RubelMozumder reviewed Apr 7, 2025
View reviewed changes
Copy link
Collaborator
@RubelMozumder RubelMozumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know it will work. Because, I think the error say there is not dist dir and probably build did not work properly.

.github/workflows/publish.yml
@@ -3,6 +3,7 @@ name: Upload Python Package
on:
release:
types: [published]
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS it intended!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because then we can redeploy manually if it fails unexpectedly

@lukaspie
Copy link
Collaborator Author
lukaspie commented Apr 7, 2025

I do not know it will work. Because, I think the error say there is not dist dir and probably build did not work properly.

This is because the built package is not available in the separate deploy step. You need to pass it along from the build to the deploy step using the artifacts upload.

RubelMozumder
RubelMozumder approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator
@RubelMozumder RubelMozumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it goes.

@lukaspie lukaspie merged commit 8bee803 into master Apr 7, 2025
17 checks passed
@lukaspie lukaspie deleted the build-artifacts branch April 7, 2025 11:25
@RubelMozumder
Copy link
Collaborator

I do not know it will work. Because, I think the error say there is not dist dir and probably build did not work properly.

This is because the built package is not available in the separate deploy step. You need to pass it along from the build to the deploy step using the artifacts upload.

I see the output was not passed to the deploy step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubelMozumder RubelMozumder RubelMozumder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaspie @RubelMozumder
0