8000 fix coveralls report and reference log generation for nexus test by lukaspie · Pull Request #631 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix coveralls report and reference log generation for nexus test #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

fix coveralls report and reference log generation for nexus test #631

merged 5 commits into from
Apr 28, 2025

Conversation

lukaspie
Copy link
Collaborator

No description provided.

@lukaspie lukaspie marked this pull request as draft April 28, 2025 09:00
@lukaspie lukaspie marked this pull request as ready for review April 28, 2025 09:37
@lukaspie lukaspie mentioned this pull request Apr 28, 2025
Merged
1 task
@lukaspie lukaspie changed the title fix coveralls report fix coveralls report and reference log generation for nexus test Apr 28, 2025
@lukaspie lukaspie requested a review from rettigl April 28, 2025 13:01
@RubelMozumder
Copy link
Collaborator

Not why the coverall is not working for python<3.12, but works for python==3.12.

https://github.com/FAIRmat-NFDI/pynxtools/actions/runs/14660792748/job/41144610789?pr=626

@RubelMozumder
Copy link
Collaborator

Not why the coverall is not working for python<3.12, but works for python==3.12.

https://github.com/FAIRmat-NFDI/pynxtools/actions/runs/14660792748/job/41144610789?pr=626

Not why the coverall is not working for python<3.12, but works for python==3.12.

https://github.com/FAIRmat-NFDI/pynxtools/actions/runs/14660792748/job/41144610789?pr=626

Ahh, this is expected behavior. So, nothing breaks in coveralls.

rettigl
rettigl approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator
@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The loadgroup for test_nexus can most likely be removed again.

@lukaspie lukaspie merged commit 8f3ffb2 into master Apr 28, 2025
17 checks passed
@lukaspie lukaspie deleted the fix-coveralls branch April 28, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaspie @RubelMozumder @rettigl
0