handle variable-name attributes in writer #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you meaning " we are now using this notation"? I thought we agreed on |
Yes, sorry. We are using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For variable-name attributes, we are now using this notation in the template:
"@AXISNAME_indices[energy_indices]"(see also https://github.com/FAIRmat-NFDI/pynxtools-mpes/pull/52/files). The existing logic was interpreting this to write an HDF5 attribute@energy_indices, but we don't actuallly want to write the@into the file. With this PR, the name of the attribute isenergy_indices, as expected.