handle broken links, add test #645
Conversation
|
pynxtools-spm and pynxtools-xrd are failing since merging #638, but they fail because of actual reasons with the individual readers (and we are a bit stricter in the validation logs now). Since Rubel is currently not available, we have agreed to ignore these failing tests for now. |
|
I am a little bit hesitant regarding the promotion of MissingRequired to "ERROR". If there are conflicts in the dict, then these could be errors, but this is just a validation issue, and does not per se invalidate the file. I find this a bit misleading, if writing a partial appdef results an an "ERROR", and would opt for reverting this. |
My reasoning was that if you check against the appdef and you miss a required element, this is an error w.r.t to what the appdef defines, i.e. it is not compliant with that particular application definition. I guess it comes down to what we want the validation to be. IMO, this is (at least) partially what NeXus is about, definining a set of concepts that have to be present for a data file to describe a given experiment. But I would be open to changing my mind here. |
Fixes #644
We could disentangle the logic of
is_documenteda bit further from checking that the key is actually valid in the future, but for now, it should be fine.