8000 Mpes updates to conversion input files by Arora0 · Pull Request #65 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mpes updates to conversion input files #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 30, 2023
Merged

Mpes updates to conversion input files #65

merged 12 commits into from
Jan 30, 2023

Conversation

Arora0
Copy link
Collaborator
@Arora0 Arora0 commented Jan 17, 2023

No description provided.

@Arora0 Arora0 requested review from domna and rettigl January 17, 2023 18:37
Copy link
Collaborator
@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as the path changes do not break any of the old examples.
I can also update the regression log file if you like.

@domna domna merged commit 896e32a into master Jan 30, 2023
@domna domna deleted the mpes-eln branch January 30, 2023 15:18
domna added a commit that referenced this pull request Feb 1, 2023
* Reader template for rii database

* Updates definitions submodule

* Adds conversion from rii to nexus dispersion formulas

* Completes writing for sellmeier polynomial and adds units refinements

* Adds remaining dispersion functions and cleanup

* Formatting

* Updates definitions submodule

* Pylinting

* Adds testing data

* Specifies encoding for reading of yml file

* Formatting

* Linting

* Adds handling of objects and additional dispersion files

* Fixes naming of dispersion groups

* Moves tabular and formula parser dicts to dispersion functions

* Fixes dispersion entry keys

* Mpes updates to conversion input files (#65)

* corrects input file paths and adds keys for dict flattening

* shifts manual metadata from example notebook 2 to eln yaml file

* corrects temp and sample pressure metadata paths and sets constant working distance

* update mpes testing log file

* remove offset from energy calibration and and rename coeffs as coefficients in config

* move sample temperature to manipulator in eln

* add manipulator to convert_dict in reader

* change temperature to celsius

* adds intrument/resolution type paths

* adds intrument/resolution paths and changes units

* update log file

* adds spatial resolution to config and updates log

* Fixes pylinting

* Changes units to parameter_units for repeated_params

* Updates submodule

* Move chemical_formula into NXsample

* Corrects submodule path

* Fix formula metadata

* Updates submodule

* Ignore definitions in pylinting

---------

Co-authored-by: Abeer Arora <61127711+Arora0@users.noreply.github.com>
RubelMozumder pushed a commit that referenced this pull request Jun 28, 2023
* corrects input file paths and adds keys for dict flattening

* shifts manual metadata from example notebook 2 to eln yaml file

* corrects temp and sample pressure metadata paths and sets constant working distance

* update mpes testing log file

* remove offset from energy calibration and and rename coeffs as coefficients in config

* move sample temperature to manipulator in eln

* add manipulator to convert_dict in reader

* change temperature to celsius

* adds intrument/resolution type paths

* adds intrument/resolution paths and changes units

* update log file

* adds spatial resolution to config and updates log
RubelMozumder pushed a commit that referenced this pull request Jun 28, 2023
* Reader template for rii database

* Updates definitions submodule

* Adds conversion from rii to nexus dispersion formulas

* Completes writing for sellmeier polynomial and adds units refinements

* Adds remaining dispersion functions and cleanup

* Formatting

* Updates definitions submodule

* Pylinting

* Adds testing data

* Specifies encoding for reading of yml file

* Formatting

* Linting

* Adds handling of objects and additional dispersion files

* Fixes naming of dispersion groups

* Moves tabular and formula parser dicts to dispersion functions

* Fixes dispersion entry keys

* Mpes updates to conversion input files (#65)

* corrects input file paths and adds keys for dict flattening

* shifts manual metadata from example notebook 2 to eln yaml file

* corrects temp and sample pressure metadata paths and sets constant working distance

* update mpes testing log file

* remove offset from energy calibration and and rename coeffs as coefficients in config

* move sample temperature to manipulator in eln

* add manipulator to convert_dict in reader

* change temperature to celsius

* adds intrument/resolution type paths

* adds intrument/resolution paths and changes units

* update log file

* adds spatial resolution to config and update
6CE0
s log

* Fixes pylinting

* Changes units to parameter_units for repeated_params

* Updates submodule

* Move chemical_formula into NXsample

* Corrects submodule path

* Fix formula metadata

* Updates submodule

* Ignore definitions in pylinting

---------

Co-authored-by: Abeer Arora <61127711+Arora0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0