drop support for python 3.8 #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuehbach
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Good, yeah py3.8 passed end-of-life
https://www.python.org/downloads/
We should add py3.13 to the test matrix, handled via #624
REBASE against latest master before merging this one !
We can't add python 3.13 because we don't support numpy v2 yet, see #624. Will have to add it later. NOMAD also does not support it yet. Once we merge here, it is probably good to make a new release and then drop py3.8 in the plugins as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.