RII parser refinements 10000 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4573b5b to
379b618
Compare
|
@sanbrock @shabihsherjeel I introduced lark as a dependency (and scipy but this was already required as a sub-dependency). I could also think of using this only as an optional dependency as it is just used for parsing the refractive index database rn. But we eventually could provide the formula parsing as a tool inside nexusututils as well. Then I'd keep the lark dependency as is. |
nexusutils/dataconverter/readers/rii_database/dispersion_functions.py
Outdated
Show resolved
Hide resolved
nexusutils/dataconverter/readers/rii_database/dispersion_functions.py
Outdated
Show resolved
Hide resolved
nexusutils/dataconverter/readers/rii_database/dispersion_functions.py
Outdated
Show resolved
Hide resolved
sherjeelshabih
approved these changes
Feb 8, 2023
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Adds stub for parsing references * Adds NX_COMPLEX as valid type * Fixes linting * Automatically convert formula to n if necessary * Adds formula parser * Updates dev-requirements * WIP: Adds writing of nxdata * Adds writing of NXdata * Bugfixes for creation of NXdata * Fixes linting * Renaming and using cdouble instead of complex128 * Use only cdouble, add csingle to valid complex types and address review comments * Updates definitions submodule * Set lower bounds for scipy and lark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the associated appdef/base classes see https://github.com/FAIRmat-Experimental/data-modeling/pull/79