Renames to pynxtools #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4766226381
💛 - Coveralls |
|
I vote for keeping it all lower case for things like pip install, etc. We can use pyNXtools for titles to Readme's, papers, etc. This is also not a necessity or rule. It just looks easier to read quickly. So to answer concisely: No. We shouldn't use pyNXtools in the name in pyproject.toml. |
sherjeelshabih
approved these changes
Apr 19, 2023
geändert: .github/workflows/pylint.yml geändert: .gitmodules modified: .github/workflows/pylint.yml
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Renames to pynxtools geändert: .github/workflows/pylint.yml geändert: .gitmodules modified: .github/workflows/pylint.yml * Properly adds definitions * Rename left over nexusutils reference from rebase * Merges xps reader.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed #88 to work from a clean repo.
As agreed in the TF meeting yesterday we rename nexusutils to pynxtools.
Wherever we refer the package we use pynxtools (in lower case). When we state it somewhere in free from text we use pyNXtools.
@shabihsherjeel Do you think we should use pyNXtools in the name in pyproject toml. Then people would need to
pip install pyNXtoolsandimport pynxtools. I typically prefer all lowercase, so I don't need to use the shift keys but I think it comes down to preference.For now I only replaced everything to the lower case variant and we may can update it as soon as we move this repo and fix the urls (mainly in the readme).
I also claimed pynxtools on pypi already (therefore the version 0.0.999 is not available anymore 😎)
Publishing should only be done after moving to the FAIRmat-NFDI organization.