8000 Atoms_typs and 'energy_scan_mood' by RubelMozumder · Pull Request #100 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Atoms_typs and 'energy_scan_mood' #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2023
Merged

Atoms_typs and 'energy_scan_mood' #100

merged 2 commits into from
May 5, 2023

Conversation

RubelMozumder
Copy link
Collaborator

Atoms_typs: ', ' somthing like this.
and energy_scan_mode: 'fixed' or 'sweep'

@coveralls
Copy link
coveralls commented Apr 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4831105197

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 58.288%
Totals Coverage Status
Change from base Build 4783861499: 0.005%
Covered Lines: 4754
Relevant Lines: 8156
💛 - Coveralls

@RubelMozumder RubelMozumder marked this pull request as ready for review May 2, 2023 09:35
@RubelMozumder RubelMozumder requested a review from domna May 2, 2023 09:36
sanbrock
sanbrock approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit 328cc50 into master May 5, 2023
@RubelMozu 93A8 mder RubelMozumder deleted the xps_bug branch June 13, 2023 15:01
@RubelMozumder RubelMozumder restored the xps_bug branch June 13, 2023 15:01
RubelMozumder added a commit that referenced this pull request Jun 28, 2023
@RubelMozumder
Atoms_typs and 'energy_scan_mood' (#100)
67921d7 
* Atoms_typs: '<elem2>, <elem2>' somthing like this.

* Re-enabling @lru_cache.

---------

Co-authored-by: RubelMozumder <rubelmozumder@outlook.com>
@RubelMozumder RubelMozumder deleted the xps_bug branch July 26, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

@domna domna Awaiting requested review from domna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubelMozumder @coveralls @sanbrock
0