8000 Ellipsometry reader + mock function by cmmngr · Pull Request #101 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ellipsometry reader + mock functio 10000 n #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 3, 2023
Merged

Ellipsometry reader + mock function #101

merged 11 commits into from
May 3, 2023

Conversation

cmmngr
Copy link
Collaborator
@cmmngr cmmngr commented Apr 28, 2023

Changes in ellips reader:

  • Optional use of mock function for ellipsometry data
  • Automatic labelling of data labelsdepending on data type and angle of incidence
  • Writing atom_types as list (if entered as string in eln_data.yaml)

Mock function:

  • random atom types, chemical formula and sample name
  • modifies spectral range, incident angles
  • random choice of data type (psi/Delta, tan(psi)/cos(delta), Mueller matrix)
  • distorts data + adds noise to data

@cmmngr cmmngr requested a review from sanbrock April 28, 2023 14:44
sanbrock
sanbrock approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit ba9e4e6 into master May 3, 2023
@sanbrock sanbrock deleted the ellips_mock branch May 3, 2023 07:30
RubelMozumder pushed a commit that referenced this pull request Jun 28, 2023
@cmmngr
Ellipsometry reader + mock function (#101)
ed2790a 
* modified reader + mock function

* correcting pylint errors

* correcting pylint errors

* correcting pylint errors

* fixing pylint errors in reader.py

* fixing pylint errors in reader.py

* fixing pylint errors in reader.py

* fixing pylint errors in reader.py

* fixing pylint errors in reader.py

* fixing pycodestyle errors in reader.py

* fixing type annotation error in mock.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmmngr @sanbrock
0