8000 DEBUG: Deleting intermeadiate generated file. by RubelMozumder · Pull Request #109 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DEBUG: Deleting intermeadiate generated file. #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

RubelMozumder
Copy link
Collaborator

Note: The temp files created in test 'test_fileline_error' mainly come from the intermediate step and the test was intended to fail. So, the created tmp file was not deleted as the entire process was not done. For that reason, the file has been created from the test by hard coding.

@RubelMozumder RubelMozumder requested a review from domna May 9, 2023 13:25
@coveralls
Copy link
coveralls commented May 9, 2023

Pull Request Test Coverage Report for Build 4926269539

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 53.677%

Totals Coverage Status
Change from base Build 4923452521: 0.03%
Covered Lines: 5058
Relevant Lines: 9423

💛 - Coveralls

@RubelMozumder RubelMozumder marked this pull request as ready for review May 9, 2023 13:29
Copy link
Collaborator
@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and problem of residual files is solved for me locally.

Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit 14ec058 into master May 9, 2023
@sanbrock sanbrock deleted the remove_test_file branch May 9, 2023 14:09
RubelMozumder added a commit that referenced this pull request Jun 28, 2023
Co-authored-by: RubelMozumder <rubelmozumder@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0