Transmission reader: Fixes readin 8000 g of detector ranges #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5024542208
💛 - Coveralls |
Comment on lines
+167
to
+169
| detector_slits[1:], | ||
| detector_times[1:], | ||
| detector_gains[1:], |
There was a problem hiding this comment.
I'm guessing this is the important change here? This looks fine how its being used below. If so, this is ready to merge. I'll approve this unless something else needs attention to.
There was a problem hiding this comment.
Yeah, this and the other line I added a comment for. Sorry that I committed my auto-formatting here, too
sherjeelshabih
approved these changes
May 19, 2023
domna
commented
May 19, 2023
| "PMT", detector_slits[2], detector_times[2], | ||
| None, 2, [wavelength_ranges[0], wavelength_ranges[1]] | ||
| "PMT", | ||
| detector_slits[-1], |
There was a problem hiding this comment.
This is also relevant to use -1 instead of 2 here. This line was actually failing if there was only one detector
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Fixes reading of detector ranges * Make linting happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in the reading of asc files if the measurement was only performed in one detector range. In this case no separate slits, gain and times are noted in the file which was failing during reading of the file.