Fixes inte 8000 rface for failing nomad tests #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
176cb6c to
8267a26
Compare
Pull Request Test Coverage Report for Build 5120292701
💛 - Coveralls |
sanbrock
requested changes
May 30, 2023
sanbrock
approved these changes
May 30, 2023
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Fixes interface for failing nomad tests * Fixes linting * Allow input file name to be a list or a str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failing tests here: https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/jobs/2181921
@sanbrock I'm not entirely sure if I should just use the first element of the list or use a for-loop. But in the failing tests this were always one-element lists so I thought it may be fine like this. But please let me know if we should solve this differently.