8000 Optionality check in nyam2nxdl by RubelMozumder · Pull Request #126 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optionality check in nyam2nxdl #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 13, 2023
Merged

Optionality check in nyam2nxdl #126

merged 9 commits into from
Jun 13, 2023

Conversation

RubelMozumder
Copy link
Collaborator

No description provided.

@RubelMozumder RubelMozumder force-pushed the optionality_check_in_nyam2nxdl branch from 9bfb548 to 04fa0c5 Compare June 12, 2023 20:45
@coveralls
Copy link
coveralls commented Jun 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5256702764

  • 35 of 65 (53.85%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 49.991%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/nyaml2nxdl/nyaml2nxdl_backward_tools.py 4 5 80.0%
pynxtools/nyaml2nxdl/nyaml2nxdl_helper.py 2 6 33.33%
pynxtools/nyaml2nxdl/nyaml2nxdl_forward_tools.py 18 43 41.86%
Files with Coverage Reduction New Missed Lines %
pynxtools/nyaml2nxdl/nyaml2nxdl_backward_tools.py 1 77.44%
pynxtools/nyaml2nxdl/nyaml2nxdl_helper.py 1 89.22%
Totals Coverage Status
Change from base Build 5251687474: 0.07%
Covered Lines: 5331
Relevant Lines: 10664
💛 - Coveralls

@RubelMozumder RubelMozumder force-pushed the optionality_check_in_nyam2nxdl branch from 04fa0c5 to 455210c Compare June 13, 2023 08:16
@RubelMozumder RubelMozumder force-pushed the optionality_check_in_nyam2nxdl branch from 455210c to c8b9487 Compare June 13, 2023 08:39
@RubelMozumder
8000
Copy link
Collaborator Author

Implementation of changes:

  1. By default all NeXus attributes, fields and groups will have 'optional' attributes if no 'optional' attributes are rendered.
  2. By default 'optional' attributes is 'false' for the application and 'true' for the base definition.
  3. By default the dim element will get the 'required' attribute and value 'true' (app def) and 'false' (base def).
  4. TEST: The 'test_attributes()' test would benefit the above properties.

@RubelMozumder RubelMozumder marked this pull request as ready for review June 13, 2023 08:43
@RubelMozumder RubelMozumder requested review from sanbrock, domna and mkuehbach and removed request for domna June 13, 2023 08:43
domna
domna reviewed Jun 13, 2023
View reviewed changes
domna
domna reviewed Jun 13, 2023
View reviewed changes
domna
domna reviewed Jun 13, 2023
View reviewed changes
8000
@RubelMozumder RubelMozumder requested a review from domna June 13, 2023 13:35
domna
domna approved these changes Jun 13, 2023
View reviewed changes
sanbrock
sanbrock requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference xml files still have unnecessary optional properties

@RubelMozumder
Copy link
Collaborator Author

Reference xml files still have unnecessary optional properties

@sanbrock, all the auto-generated 'optional' has been removed. Still, some of the 'optional' keyword are left, they are not auto-generated but rather from changes of yaml.

@RubelMozumder RubelMozumder requested a review from sanbrock June 13, 2023 14:32
sanbrock
sanbrock approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit 61a6f1a into master Jun 13, 2023
@sanbrock sanbrock deleted the optionality_check_in_nyam2nxdl branch June 13, 2023 14:45
RubelMozumder added a commit that referenced this pull request Jun 28, 2023
@RubelMozumder
Optionality check in nyam2nxdl (#126)
c0be8c4 
* temporary changes.

* Including some changes for optionality error.

* Passing test successfully. Cleaning up some tests.

* Removing autogenerated 'optional' attribute from nxdl.xml.

* Removing autogenerated 'optional' attribute from nxdl.xml.

* Removing autogenerated 'optional' attribute from nxdl.xml.

* Removing autogenerated 'optional' attribute from nxdl.xml.

* Comments or corrections are resolved.

* Corrections from review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

@sanbrock sanbrock sanbrock approved these changes

@mkuehbach mkuehbach Awaiting requested review from mkuehbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RubelMozumder @coveralls @domna @sanbrock
0