-
Notifications
You must be signed in to change notification settings - Fork 10
Add parsing of Scienta text export #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- Parse exported TXT files from Scienta vendor
- Mapping from scienta_txt_parser to NXmpes]
- Add the possibility of having multiple XPS data files such that each file can have multiple entries in the resulting NeXus file
- Extract all lines from Scienta .txt export file - Read out data and region meta data. 8000 - Store all in a flat list of dictionaries, with each dict containing one spectrum.
- Add class ScientaTxtSpecs for mapping from scienta_txt_parser output to NXmpes-ready dictionary - Move methods for key construction to function level (reused in all Specs classes) - Add new reader to the XpsDataFileParser readers - Update error messages
- Change allowed file extensions in XPS reader - Add config file for Scienta txt reader
- Since in the TXT export, the data for each channel is not given, we use the exported counts as the raw detector data.
- In the read method of the XPSReader, if there are two data files (e.g. with file extensions ".sle", ".xml", ".txt"), ensure that existing keys are not overwritten (especially 'data'). - Instead, the existing values of existing keys are extended, dependent on the type of the value.
Pull Request Test Coverage Report for Build 5280291390
💛 - Coveralls |
- Use merged_dict = {**dict1, **dict2} instead of merged_dict =dict1 | dict2
Pull Request Test Coverage Report for Build 5281037287
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5297723828
💛 - Coveralls |
lukaspie
commented
Jun 16, 2023
lukaspie
commented
Jun 16, 2023
Dicts are merged and every other object is appended to a list.
RubelMozumder
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.