8000 Refactor nexus.py by PeterC-DLS · Pull Request #131 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor nexus.py #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Refactor nexus.py #131

merged 3 commits into from
Jun 20, 2023

Conversation

PeterC-DLS
Copy link
Contributor

To separate out functions and classes not related to reading NeXus files

To separate out functions and classes not related to reading NeXus files
@sanbrock
Copy link
Collaborator

There are still some more functions which need h5py

@PeterC-DLS PeterC-DLS force-pushed the nexus-refactor branch 3 times, most recently from 5280091 to 9803f7b Compare June 19, 2023 13:35
@coveralls
Copy link
coveralls commented Jun 19, 2023

Pull Request Test Coverage Report for Build 5320612967

  • 383 of 507 (75.54%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 49.486%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/nexus/nexus.py 24 29 82.76%
pynxtools/nexus/nxdl_utils.py 359 478 75.1%
Totals Coverage Status
Change from base Build 5308808715: 0.06%
Covered Lines: 5388
Relevant Lines: 10888

💛 - Coveralls

@sanbrock sanbrock merged commit 2d33a22 into FAIRmat-NFDI:master Jun 20, 2023
@PeterC-DLS PeterC-DLS deleted the nexus-refactor branch June 20, 2023 11:55
RubelMozumder pushed a commit that referenced this pull request Jul 3, 2023
* Refactor nexus.py

To separate out functions and classes not related to reading NeXus files

* Add back some functions

* Do a little more refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0