8000 Enable Rubel, updated spm deps and fixing pytests by mkuehbach · Pull Request #142 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable Rubel, updated spm deps and fixing pytests #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Enable Rubel, updated spm deps and fixing pytests #142

merged 1 commit into from
Jul 31, 2023

Conversation

mkuehbach
Copy link
Collaborator

No description provided.

Fixed deps to point to ff35ff7 of the nexus_definitions spm branch wh…
599252d 
…ich is exactly the state if PR33 will have been merged (currently blocked by one review), fixed pytest, note for fixing the test_nexus.py: the test writes results from several tests in one log file, remove everything after 1895 before copying the copy from pytest, see also the following commit on pynxtools which helps clarify the issue ed1cf73
@mkuehbach mkuehbach requested a review from RubelMozumder July 31, 2023 13:19
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 5715208735

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 49.454%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/readers/em_nion/concepts/swift_handle_nx_concepts.py 1 11.86%
pynxtools/nyaml2nxdl/nyaml2nxdl_forward_tools.py 1 79.42%
tests/dataconverter/test_writer.py 1 96.77%
pynxtools/nexus/nxdl_utils.py 2 74.58%
Totals Coverage Status
Change from base Build 5542079515: -0.05%
Covered Lines: 5385
Relevant Lines: 10889
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5715208735

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.504%
Totals Coverage Status
Change from base Build 5542079515: 0.0%
Covered Lines: 5391
Relevant Lines: 10890
💛 - Coveralls

@RubelMozumder
Copy link
Collaborator

All CI/CD passed.

RubelMozumder
RubelMozumder approved these changes Jul 31, 2023
View reviewed changes
Copy link
9940
Collaborator
@RubelMozumder RubelMozumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice all conflicts are resolved!

@RubelMozumder RubelMozumder merged commit 8f1f050 into master Jul 31, 2023
@RubelMozumder RubelMozumder deleted the spm_nxdef_deps branch July 31, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubelMozumder RubelMozumder RubelMozumder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkuehbach @coveralls @RubelMozumder
0