-
Notifications
You must be signed in to change notification settings - Fork 10
Write NXroot attributes #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 6640766175
💛 - Coveralls |
We should also add the standard NXroot attributes here:
See here for full reference |
I'll add NeXus_version once you're stable with #162
These don't work for us. The first is the hdf4 version. And we don't write any XML here.
|
This works fine for me, however I get undocumented field warnings when I execute this on my example files:
Interestingly, I don't get an undocumented warning for |
The NXroot objects are not added during Template generation. This means when I add them, they get added to the undocumented part of the Template. I don't want to re-run them and figure out their validity. It's too expensive. Here, we know that the code is producing them correctly anyways. So I just skip over those checks. Now, you won't get the undocumented warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect now :)
I can also add the NeXus_version
attribute in #162 if you want to merge this already.
Fixes #163.
This allows the Template to now accept NXroot level NXobjects. I have made a test with /@default.
Note: This makes the undocmuented warning test do nothing.