8000 Python 3.11 support by domna · Pull Request #177 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Python 3.11 support #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 30, 2023
Merged

Python 3.11 support #177

merged 9 commits into from
Nov 30, 2023

Conversation

domna
Copy link
Collaborator
@domna domna commented Nov 10, 2023 •
edited
Loading

I think it would be good to start extending the support matrix to newer versions.

@lukaspie
Copy link
Collaborator

Currently, ifes_apt_tc_data_modeling is blocking the tests because v0.0.9 requires Python <3.11, >=3.8. @mkuehbach could you check if newer python versions could also work for this tool?

@mkuehbach
Copy link
Collaborator

Hi @lukaspie, in principle that lib should also work for 3.11, at the point when the v0.0.9 was written that was not tested though and thus I switched py311 off. As I was planning to start on Monday anyways on implementing the ATO and APT parser for the FAU Erlangen examples, I would then test this with 3.11 and 3.12 and bump the ifes lib accordingly then

@domna domna force-pushed the newer-python-support branch from e87f8d6 to 88351e3 Compare November 28, 2023 15:39
@coveralls
Copy link
coveralls commented Nov 28, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 7045506775

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 51.02%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/helpers.py 1 96.28%
pynxtools/nexus/nxdl_utils.py 1 75.16%
tests/dataconverter/test_writer.py 1 96.77%
pynxtools/dataconverter/convert.py 21 80.34%
Totals Coverage Status
Change from base Build 7017248188: -0.6%
Covered Lines: 5827
Relevant Lines: 11421
💛 - Coveralls

@domna
Copy link
Collaborator Author
domna commented Nov 29, 2023

Currently, numba is not available for python 3.12. They are working on this: numba/numba#9197

I will set the maximum python version to 3.11 here, so we at least can support this version. We can then add python 3.12 support as soon as numb 0.59 is released.

@domna domna changed the title Python 3.11 and 3.12 support Python 3.11 support Nov 29, 2023
mkuehbach
mkuehbach reviewed Nov 30, 2023
View reviewed changes
@domna domna merged commit 55ac094 into master Nov 30, 2023
@domna domna deleted the newer-python-support branch November 30, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuehbach mkuehbach mkuehbach approved these changes

@sherjeelshabih sherjeelshabih Awaiting requested review from sherjeelshabih

@lukaspie lukaspie Awaiting requested review from lukaspie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domna @lukaspie @mkuehbach @coveralls
0