Fix build via python -m build
#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rettigl The package generation currently fails (see https://github.com/FAIRmat-NFDI/pynxtools/actions/runs/6982526131/job/19001851868). This PR fixes it and afterwards I can publish the package and re-generate the containers. |
Pull Request Test Coverage Report for Build 6982705544
💛 - Coveralls |
sherjeelshabih
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build via the python build method for wheel and sdist generation. It fails if the
nexus-version.txtis not already present, so the code should just return to not write the file again if the code is not in a github repository anymore.Previously, this was unnoticed because it works when the file was generated before.