8000 Adds a get method to Dataconverter Template by sherjeelshabih · Pull Request #190 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds a get method to Dataconverter Template #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

Adds a get method to Dataconverter Template #190

merged 3 commits into from
Dec 4, 2023

Conversation

sherjeelshabih
Copy link
Collaborator

No description provided.

@sherjeelshabih sherjeelshabih requested a review from domna December 2, 2023 11:18
@sherjeelshabih sherjeelshabih mentioned this pull request Dec 2, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 2, 2023

Pull Request Test Coverage Report for Build 7069869231

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.09%) to 50.941%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/template.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/convert.py 1 79.49%
pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py 1 11.86%
pynxtools/nyaml2nxdl/nyaml2nxdl_forward_tools.py 1 79.42%
pynxtools/dataconverter/helpers.py 2 95.74%
pynxtools/nexus/nxdl_utils.py 2 74.74%
Totals Coverage Status
Change from base Build 7045854627: -0.09%
Covered Lines: 5820
Relevant Lines: 11425
💛 - Coveralls

@coveralls
Copy link
coveralls commented Dec 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7083703361

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 52.081%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/template.py 5 8 62.5%
Totals Coverage Status
Change from base Build 7076046046: -0.04%
Covered Lines: 6145
Relevant Lines: 11799
💛 - Coveralls

RubelMozumder
RubelMozumder reviewed Dec 2, 2023
View reviewed changes
RubelMozumder
RubelMozumder reviewed Dec 2, 2023
View reviewed changes
RubelMozumder
RubelMozumder approved these changes Dec 3, 2023
View reviewed changes
@sherjeelshabih sherjeelshabih removed the request for review from domna December 3, 2023 11:35
@sherjeelshabih sherjeelshabih merged commit 8620c4e into master Dec 4, 2023
@sherjeelshabih sherjeelshabih deleted the get-method-template branch December 4, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubelMozumder RubelMozumder RubelMozumder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherjeelshabih @coveralls @RubelMozumder
0