8000 Always install importlib-metadata (not only for <3.10) and provide dummy entry_points by domna · Pull Request #195 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Always install importlib-metadata (not only for <3.10) and provide dummy entry_points #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

domna
Copy link
Collaborator
@domna domna commented Dec 4, 2023

The version dependent install of the backporting importlib-metadata sparked some problems with nomad's dependency resolving. Here, I bring that importlib-metadata is always installed, regardless of the python version.

It also provides a dummy entry_points if importlib-metadata cannot be imported.

@domna domna requested a review from RubelMozumder December 4, 2023 17:28
Copy link
Contributor
github-actions bot commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7097402805

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 44.553%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/convert.py 2 5 40.0%
Totals Coverage Status
Change from base Build 7086717544: -0.008%
Covered Lines: 4863
Relevant Lines: 10915

💛 - Coveralls

@domna domna changed the title Always install importlib-metadata (not only for <3.10) Always install importlib-metadata (not only for <3.10) and provide dummy entry_points Dec 5, 2023
@domna domna merged commit 2c4150b into master Dec 5, 2023
@domna domna deleted the fix-importlib-dependency branch December 5, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0