Dataconverter param file #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbrock
reviewed
Jun 27, 2022
| conv_params["output"] = f"{base_dir}{os.sep}{check_path(conv_params['output'])}" | ||
| convert(**conv_params) | ||
| mainfile = conv_params["output"] | ||
|
|
||
| nexus_helper = read_nexus.HandleNexus(logger, [mainfile]) |
There was a problem hiding this comment.
Won't NOMAD try to parse the freshly generated new NeXus file anyway?
There was a problem hiding this comment.
The Nomad walk over the files doesn't win the race here. The user can press reprocess to have another entry for the NXS file. It's hard to enforce this and can lead to unexpected behavior.
I've went with this additional feature in h5web in Nomad that allows us to show the Nexus file assosciated with the dataconverter parameter file. Here is the relevant MR: https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/734
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Added params file parsing to dataconverter * Added auto convert when files get parsed through Nomad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to recieve a parameter file for the data converter and also allows us to trigger the converter in the Nomad GUI by uploading such a parameter YAML file.