8000 Add pynxtools-xps as extra install by lukaspie · Pull Request #265 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add pynxtools-xps as extra install #265

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

lukaspie
Copy link
Collaborator

Following the initial release of pynxtools at https://pypi.org/project/pynxtools-xps/, allow for installing with pynxtools as an extra install.

@lukaspie lukaspie requested a review from domna February 26, 2024 16:04
@lukaspie
Copy link
Collaborator Author

Currently breaking tests because of ifes_act_tc_data_modeling==0.9 in pyproject.toml, see #263.

Copy link
Collaborator
@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and good to go as soon as the ase/ifes issue is fixed

@coveralls
Copy link
coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 8201037708

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.768%

Totals Coverage 
8000
Status
Change from base Build 8018663342: 0.0%
Covered Lines: 3596
Relevant Lines: 7857

💛 - Coveralls

@lukaspie lukaspie merged commit 1f9e86e into master Mar 8, 2024
@lukaspie lukaspie deleted the add-pynxtools-xps-to-extras branch March 8, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0