8000 Removes transmission and hall readers by domna · Pull Request #285 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removes transmission and hall re 8000 aders #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

domna
Copy link
Collaborator
@domna domna commented Mar 18, 2024

This removes the transmission and hall readers as they are managed by nomad plugins now.

Fyi: @aalbino2, @ka-sarthak (could you post the links of the respective plugins here so the development can be followed?)

@domna domna requested a review from sherjeelshabih March 19, 2024 08:41
@coveralls
Copy link
coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8342377579

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+1.1%) to 77.768%

Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_readers.py 1 92.86%
pynxtools/dataconverter/convert.py 1 75.43%
pynxtools/dataconverter/readers/json_yml/reader.py 2 84.62%
pynxtools/dataconverter/readers/utils.py 32 40.87%
Totals Coverage Status
Change from base Build 8341446964: 1.1%
Covered Lines: 2599
Relevant Lines: 3342

💛 - Coveralls

@andreaa93
Copy link
Collaborator

LGTM

@domna domna force-pushed the remove-transmission-and-hall branch from a60b61f to 466932c Compare March 19, 2024 11:41
@domna domna merged commit 3afcbd2 into master Mar 19, 2024
@domna domna deleted the remove-transmission-and-hall branch March 19, 2024 22:38
mkuehbach pushed a commit that referenced this pull request Mar 21, 2024
* Removes transmission and hall readers

* Remove hall in tests

* Remove pytz
RubelMozumder pushed a commit that referenced this pull request Mar 26, 2024
* Removes transmission and hall readers

* Remove hall in tests

* Remove pytz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0