8000 Remove em-specific dataconverters as their functionality is superseed… by mkuehbach · Pull Request #286 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove em-specific dataconverters as their functionality is superseed… #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

mkuehbach
Copy link
Collaborator

…ed by the pynxtools-em plugin, implementing a contribution for #283

…ed by the pynxtools-em plugin, implementing a contribution for #283
@mkuehbach
Copy link
Collaborator Author

Adding em-specific part to make pynxtools a cool plugin system. Development for em continues here on pynxtools-em.

@mkuehbach
Copy link
Collaborator Author

Associated with this PR we should check all of us if the following hefty deps are really required for pynxtools:

  • scipy
  • pandas

Yeah they come in with many python packages right now but if somebody uses a bare installation of pynxtools with just one tool why would one need a complete scipy and or pandas installation? Point is the dependencies of the base pynxtools should be as small as possible.

@mkuehbach
Copy link
Collaborator Author

When merged, I create another PR for merging the mmov_em_apm_announcement and with this closing the issue pluginization of apm and em as far as the base pynxtools is concerned

@domna
Copy link
Collaborator
domna commented Mar 19, 2024

Could you merge this to your other branch and then create a new PR on the main branch? That way the CI/CD runs (it only runs for PRs targeting the main branch). We can then review the other PR, as far as I see it currently only contains some doc changes.

@mkuehbach mkuehbach merged commit 9fc0bb7 into mmov_em_apm_announcement Mar 19, 2024
@mkuehbach mkuehbach deleted the em-moved-to-pynxtools-em branch April 16, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0